[Freeipa-devel] [PATCH] 0031 ipa-restore: Check if directory is provided + better errors.

Tomas Babej tbabej at redhat.com
Fri Nov 21 12:42:42 UTC 2014


On 11/21/2014 01:33 PM, David Kupka wrote:
> https://fedorahosted.org/freeipa/ticket/4683
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

-            self.read_header()
+            try:
+                self.read_header()
+            except:
+                raise admintool.ScriptError('Cannot read backup metadata')


Is the bare except clause really necessary?

https://docs.python.org/2.7/howto/doanddont.html#except


-- 
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20141121/fa77a8f1/attachment.htm>


More information about the Freeipa-devel mailing list