[Freeipa-devel] [PATCHES] 366-372 Additional Coverity fixes

Alexander Bokovoy abokovoy at redhat.com
Tue Nov 25 08:13:58 UTC 2014


On Tue, 11 Nov 2014, Jan Cholasta wrote:
>>From c2a03a9e062df5691431babeb55119dbda6b2c67 Mon Sep 17 00:00:00 2001
>From: Jan Cholasta <jcholast at redhat.com>
>Date: Mon, 10 Nov 2014 17:20:18 +0000
>Subject: [PATCH 1/7] Remove redefinition of LOG from ipa-otp-lasttoken
>
>https://fedorahosted.org/freeipa/ticket/4713
>---
> daemons/ipa-slapi-plugins/ipa-otp-lasttoken/ipa_otp_lasttoken.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/daemons/ipa-slapi-plugins/ipa-otp-lasttoken/ipa_otp_lasttoken.c b/daemons/ipa-slapi-plugins/ipa-otp-lasttoken/ipa_otp_lasttoken.c
>index d20fca1..15b404d 100644
>--- a/daemons/ipa-slapi-plugins/ipa-otp-lasttoken/ipa_otp_lasttoken.c
>+++ b/daemons/ipa-slapi-plugins/ipa-otp-lasttoken/ipa_otp_lasttoken.c
>@@ -47,9 +47,6 @@
> #include "util.h"
> 
> #define PLUGIN_NAME               "ipa-otp-lasttoken"
>-#define LOG(sev, ...) \
>-    slapi_log_error(SLAPI_LOG_ ## sev, PLUGIN_NAME, \
>-                    "%s: %s\n", __func__, __VA_ARGS__), -1
> 
> static void *plugin_id;
> static const Slapi_PluginDesc preop_desc = {
ACK, this definition, while it differs from what is in util.h, is not
used anywhere in ipa_otp_lasttoken.c

-- 
/ Alexander Bokovoy




More information about the Freeipa-devel mailing list