[Freeipa-devel] [PATCH] 0033 Use singular in help metavars + update man pages.

[David Kupka]

On 11/26/2014 12:23 PM, Martin Basti wrote:
> On 25/11/14 15:44, David Kupka wrote:
>> On 11/25/2014 03:23 PM, Martin Basti wrote:
>>> On 25/11/14 13:16, David Kupka wrote:
>>>> On 11/25/2014 09:57 AM, David Kupka wrote:
>>>>> On 11/25/2014 09:51 AM, David Kupka wrote:
>>>>>> On 11/24/2014 03:59 PM, Martin Basti wrote:
>>>>>>> On 24/11/14 15:54, David Kupka wrote:
>>>>>>>> https://fedorahosted.org/freeipa/ticket/4695
>>>>>>>>
>>>>>>>> IMO this is one of two reasonable ways how to fix this ticket.
>>>>>>>> The other one is to change just the manual page but it seems more
>>>>>>>> consistent to use singular for metavars everywhere.
>>>>>>>>
>>>>>>>>
>>>>>>> I like this approach. But IMO we should instead of "You ..." form in
>>>>>>> help, this message, as we use with forwarders
>>>>>>>
>>>>>>> "This option can be used multiple times"
>>>>>>>
>>>>>>> Martin^2
>>>>>>>
>>>>>> Our manual pages are not exactly unified in that but let's stay with
>>>>>> the
>>>>>> majority.
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Freeipa-devel mailing list
>>>>>> Freeipa-devel at redhat.com
>>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>>>>
>>>>> Wrong patch, sorry.
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Freeipa-devel mailing list
>>>>> Freeipa-devel at redhat.com
>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>>>
>>>> Extending help messages too.
>>>>
>>> NACK, you edited wrong option
>>>
>>>   --no-reverse        Do not create reverse DNS zone. This option can be
>>>                          used multiple times
>>>
>>>
>> Bad line, thanks for noticing, fixed patches attached.
>>
> ./make-lint
> ************* Module ipaserver.install.ipa_replica_prepare
> ipaserver/install/ipa_replica_prepare.py:59: [E0001(syntax-error), ]
> invalid syntax)
> ************* Module ipa-replica-prepare
> install/tools/ipa-replica-prepare:21: [E0611(no-name-in-module), ] No
> name 'ipa_replica_prepare' in module 'ipaserver.install')
>
>
Fixed.

-- 
David Kupka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-dkupka-0033-5-master-Use-singular-in-help-metavars-update-man-pages.patch
Type: text/x-patch
Size: 12546 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20141126/763d1487/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-dkupka-0033-5-Use-singular-in-help-metavars-update-man-pages.patch
Type: text/x-patch
Size: 12545 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20141126/763d1487/attachment-0001.bin>