[Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

[Gabe Alford]

This patch removes the app_PYTHON usage.

Thanks,

Gabe

On Thu, Nov 27, 2014 at 9:40 AM, Martin Kosek <mkosek at redhat.com> wrote:

> Exactly, this was the message from Martin :-) I did not test it myself, but
> removing all app_PYTHON should be benign given we use Python setup.py
> packaging.
>
> On 11/27/2014 04:27 PM, Gabe Alford wrote:
> > Thanks guys. Sounds like it would be better to submit a patch that
> removes
> > app_PYTHON if it is considered dead code.
> >
> > Gabe
> >
> > On Thursday, November 27, 2014, Petr Spacek <pspacek at redhat.com> wrote:
> >
> >> On 27.11.2014 11:00, Martin Basti wrote:
> >>> On 27/11/14 00:50, Gabe Alford wrote:
> >>>> Hello,
> >>>>
> >>>>        Wondering if I could get a review. Updated patch attached.
> >>>>
> >>>> Thanks,
> >>>> Gabe
> >>>>
> >>>> On Tue, Nov 11, 2014 at 7:21 AM, Gabe Alford <redhatrises at gmail.com
> >> <javascript:;>
> >>>> <mailto:redhatrises at gmail.com <javascript:;>>> wrote:
> >>>>
> >>>>     Hello,
> >>>>
> >>>>     Fix for https://fedorahosted.org/freeipa/ticket/4700
> >>>>
> >>>>     Thanks,
> >>>>
> >>>>     Gabe
> >>>>
> >>>>
> >>>>
> >>> Hello,
> >>>
> >>> sorry for late response.
> >>>
> >>> We push this ticket to backlog, as it would be part of build system
> >> refactoring.
> >>> The "app_PYTHON" statement is not used anymore in IPA, the better
> >> solution is
> >>> remove it, instead of keeping dead code up-to-date.
> >>
> >> Just to clarify:
> >> It can be pushed if it works, there is no need to postpone accepting
> patch
> >> if
> >> the patch seems okay and doesn't break anything.
> >>
> >> Martin, please keep in mind that contributions are welcome at any time.
> >>
> >> Milestones in Trac reflect our view of priorities but it doesn't
> prevent us
> >> from accepting correct patches from contributions at any time, no matter
> >> which
> >> priority is stated in Trac (or even if there is no ticket for it ...).
> >>
> >> --
> >> Petr^2 Spacek
> >>
> >> _______________________________________________
> >> Freeipa-devel mailing list
> >> Freeipa-devel at redhat.com <javascript:;>
> >> https://www.redhat.com/mailman/listinfo/freeipa-devel
> >>
> >
> >
> >
> > _______________________________________________
> > Freeipa-devel mailing list
> > Freeipa-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/freeipa-devel
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20141129/c10ab032/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rga-0036-3-Add-missing-python-files-to-Makefiles.patch
Type: text/x-patch
Size: 3469 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20141129/c10ab032/attachment.bin>