[Freeipa-devel] [PATCH] 779 webui: do not show closed dialog

[Endi Sukma Dewata]

On 10/20/2014 12:22 PM, Petr Vobornik wrote:
> Fixes issues when dialog is not removed from `IPA.opened_dialogs`
> registry when dialog.close() is called while the dialog is not shown,
> i.e., while other dialog is shown. Without it, the dialog is could be
> incorrectly displayed.
>
> New dialog's property `opened` handles whether dialog is intended to be
> opened.
>
> How to test:
>
> Add new host with IP address outside of managed reverse zones to get
> error 4304.

Didn't have a chance to test it, but the code looks fine. ACK.
Perhaps the 'opened' property can be renamed to 'enabled' or something 
like that to avoid confusions with 'is_shown'.

-- 
Endi S. Dewata