[Freeipa-devel] [PATCH[ 0639 permission plugin: Make --target available in the CLI

[Martin Kosek]

On 09/03/2014 12:43 PM, Petr Viktorin wrote:
> On 09/03/2014 12:26 PM, Martin Kosek wrote:
>> On 09/03/2014 12:17 PM, Petr Viktorin wrote:
>>> This fixes https://fedorahosted.org/freeipa/ticket/4522. The API is already
>>> tested and the attribute is available in the UI.
>>>
>>> Pushed as one-liner to:
>>> ipa-4-0: 1044d09333114058bf38df501acc12708329af73
>>> ipa-4-1: c01c61618d5e768fde0376b2f46b4887308f7a86
>>> master: 4fbba3f7b86e4e7c8890911da650a3b55cc9a046
>>
>> Given that we now publish this attribute in CLI, shouldn't we improve it's
>> label and docs? I am not sure if just plain "ACI target DN" is useful for
>> anyone not very familiar with ACI structure.
> 
> You're right, as always

Heh, I have my moments :)

>> Maybe we should label it as just "Target DN" with docs something like "Optional
>> DN to apply permissions to (can be used on top of Subtree)"
> 
> Instead I parenthesized the major limitation (specifying a target outside of
> subtree will give an ACI error) and the usual use case.
> Does this look OK?

It does - ACK.

Thanks,
Martin