[Freeipa-devel] [PATCH 0260] ipa-client-install: Do not add already configured sources to

[Tomas Babej]

On 09/03/2014 04:53 PM, Petr Viktorin wrote:
> On 09/03/2014 03:53 PM, Tomas Babej wrote:
>> Hi,
>>
>> Makes sure that any new sources added are not already present
>> in the entry.
>>
>> https://fedorahosted.org/freeipa/ticket/4508
>
> It works fine, ACK.
>
> I do have some comments, but 4.0.x is a stabilization release, so
> they'd probably be better in a 4.1 patch:
>
> The way you first join default_value to make configured_services, and
> then repeatedly split it, looks quite wasteful. Wouldn't
> configured_services be better as a list?

Yes, the string handling was kind of unfortunate. I fixed it in this
iteration of the patch.

> Also I wonder if configure_nsswitch_database needs those unused
> preserve/append options.

Although not used yet, I think it's handy to have them there, they do
not complicate the code much.

>
> Should I push now?
>

-- 
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0260-2-ipa-client-install-Do-not-add-already-configured-sou.patch
Type: text/x-patch
Size: 2886 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140904/bd0c6391/attachment.bin>