[Freeipa-devel] [PATCH] 746-747 append domain into network.negotiate-auth.trusted-uris

[Petr Vobornik]

On 4.9.2014 21:26, Endi Sukma Dewata wrote:
> On 8/29/2014 11:00 AM, Petr Vobornik wrote:
>> [PATCH] 746 webui: append network.negotiate-auth.trusted-uris
>>
>> https://fedorahosted.org/freeipa/ticket/4478
>
> Some comments/questions:
>
> 1. If I'm reading this correctly, if the preference is currently empty,
> the method will just return without setting the new value.

Fixed. Yes, even if there was 'continue', it would be wrong.

>
> 2. If the new value already exists, the method will just return.
> Shouldn't it "continue" with the rest of the loop instead of "return"?
> This applies to #1 as well.

Yes, fixed.

>
> 3. Using indexOf() to find a URI in a string can produce false matches.
> For example, aa.com will match baa.com. Ideally the existing value
> should be parsed into a collection of URI's, then the new URI should be
> matched using a proper URI matching algorithm.

Fixed with function which matches splitted and striped values using 
strict equality.

>
>> [PATCH] 747 install: create ff krb extension on every install, replica
>> install and upgrade
>>
>> We don't want to copy the extension from master to replica because the
>> replica may use newer version of FreeIPA and therefore the extension
>> code might be obsolete. Same reason for upgrades.
>>
>> https://fedorahosted.org/freeipa/ticket/4478
>
> ACK.
>


-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0746-1-webui-append-network.negotiate-auth.trusted-uris.patch
Type: text/x-patch
Size: 2493 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140910/b63a39c9/attachment.bin>