[Freeipa-devel] [PATCH 0298-0302] Implement handling of inactive master zones

[Petr Viktorin]

On 09/22/2014 02:01 PM, Martin Basti wrote:
> On 19/09/14 15:46, Petr Spacek wrote:
>> Hello,
>>
>> This patch set fixes
>> https://fedorahosted.org/bind-dyndb-ldap/ticket/127
>> https://bugzilla.redhat.com/show_bug.cgi?id=1138317
>>
>> Please review it ASAP, it targets IPA 4.1/Fedora 21.
>>
>> Tomas and Martin, please communicate who is going to review what :-)
>>
>> Thank you for your time!
>>
> functional ACK, but wait for Tomas' ACK as well.
>
> my tests:
> * disable zone
> * enable zone
> * add record to disabled zone
> * delete record from disabled zone
> * add record to enabled zone
> * delete record from enabled zone
> * disable DNSSEC, enabled zone
> * enable DNSSEC, enabled zone
> * disable DNSSEC, disabled zone
> * enable DNSSEC, disabled zone
> * add disabled zone
> * delete disabled zone
> * add disabled zone with dnssec
> * delete disabled zone with dnssec
> * add zone
> * delete zone
> * disable zone without valid NS record
> * enable zone without valid NS record
> * Enable zone, Enable DNSSEC, Disable DNSSEC, disable zone, Enable
> DNSSEC in Disabled zone, Enable zone
> * freeIPA DNS tests
> * some random tests

Could you ideally send a patch with these?
Integration tests aren't very hard to write -- see 
ipatests/test_integration/test_service_permissions.py

-- 
Petr³