[Freeipa-devel] [PATCHES 0114-0115, 0120-0121, 0123-0125] DNS: allow to add root zone '.'

[Martin Basti]

On 19/09/14 13:54, Martin Kosek wrote:
> I did not review, just found something that hit me in the eyes:
>
>
> On 09/19/2014 01:25 PM, Martin Basti wrote:
>> +class OptionDeprecatedWarning(PublicMessage):
>> +    """
>> +    **13004** Used when user uses a deprecated option
>> +    """
>> +
>> +    errno = 13004
>> +    type = "warning"
>> +    format = _(u"'%(option)s' option is deprecated. 
>> %(additional_info)s")
>> +
>> +
>> +class OptionNameServerWarning(PublicMessage):
>> +    """
>> +    **13005** Used when user uses a dnszone-add/mod --name-server 
>> option
>> +    """
>> +
>> +    errno = 13005
>> +    type = "warning"
>> +    format = _(u"'--name-server' is used only for setting up the SOA 
>> MNAME attribute.\n"
>> +               u"To edit NS record(s) in zone apex, use command 
>> 'dnsrecord-mod [zone] @ --ns-rec=nameserver'.")
>
>
> OptionNameServerWarning has a nice generic name, but the format is not 
> that generic, compared to OptionDeprecatedWarning. I think we should 
> follow the approach as in OptionDeprecatedWarning so that the warning 
> can be reused.
>
> This is not urgent though, you can wait with the fix until Petr2 or 
> somebody else sends you other notes...
>
> Martin

Updated patchset attached

-- 
Martin Basti

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0114.3-Fix-DNS-plugin-to-allow-to-add-root-zone.patch
Type: text/x-patch
Size: 4904 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140922/387cd167/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0115.3-DNS-test-allow-.-as-zone-name.patch
Type: text/x-patch
Size: 4529 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140922/387cd167/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0120.3-Deprecation-of-name-server-and-ip-address-option-in-.patch
Type: text/x-patch
Size: 12753 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140922/387cd167/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0121.3-Add-correct-NS-records-during-installation.patch
Type: text/x-patch
Size: 9987 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140922/387cd167/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0123.3-DNS-autofill-admin-email.patch
Type: text/x-patch
Size: 7403 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140922/387cd167/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0124.3-WebUI-DNS-Remove-ip-address-admin-email-options.patch
Type: text/x-patch
Size: 3281 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140922/387cd167/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0125.3-DNS-tests-tests-update-to-due-to-change-in-options.patch
Type: text/x-patch
Size: 62061 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140922/387cd167/attachment-0006.bin>