[Freeipa-devel] [PATCHES 0114-0115] DNS: allow to add root zone '.'

[Petr Viktorin]

On 09/23/2014 05:45 PM, Petr Vobornik wrote:
> On 25.8.2014 14:52, Martin Basti wrote:
[...]
> 1. Please follow pep8 for the new code.
>   # git diff HEAD~7 -U0 | pep8 --diff --ignore=E501
> Produces 25 erros.
>
> Only E124 and E128 could be ignored if they are part of old code.

FWIW, our style guide is PEP 8 the document [0], not pep8 the tool. The 
document lists these "other good reasons to ignore a particular guideline":

1. When applying the guideline would make the code less readable, even 
for someone who is used to reading code that follows this PEP.
2. To be consistent with surrounding code that also breaks it (maybe for 
historic reasons) -- although this is also an opportunity to clean up 
someone else's mess (in true XP style).
3. Because the code in question predates the introduction of the 
guideline and there is no other reason to be modifying that code.
4. When the code needs to remain compatible with older versions of 
Python that don't support the feature recommended by the style guide.


Anyway: there is no blanket exception for "Limit all lines to a maximum 
of 79 characters" (which pep8 calls E501). Some IPA developers do use 
several columns of code side by side.


[0] http://legacy.python.org/dev/peps/pep-0008/

-- 
Petr³