[Freeipa-devel] [PATCH] 129 ipa-kdb: fix unit tests

[Jakub Hrozek]

On Tue, Jul 22, 2014 at 05:24:51PM +0200, Sumit Bose wrote:
> Hi,
> 
> it looks like the ipa-kdb unit test is broken. This patch tries to fix
> it.
> 
> bye,
> Sumit

ACK

Without the patch, I got:
ipa_kdb_tests-ipa_kdb_common.o: In function `ipadb_ldap_attr_has_value':
/home/remote/jhrozek/devel/freeipa/daemons/ipa-kdb/ipa_kdb_common.c:531: undefined reference to `ulc_casecmp'
ipa_kdb_tests-ipa_kdb_principals.o: In function `ipadb_find_principal':
/home/remote/jhrozek/devel/freeipa/daemons/ipa-kdb/ipa_kdb_principals.c:778: undefined reference to `ulc_casecmp'
ipa_kdb_tests-ipa_kdb_mspac.o: In function `ipadb_sign_authdata':
/home/remote/jhrozek/devel/freeipa/daemons/ipa-kdb/ipa_kdb_mspac.c:2067: undefined reference to `ulc_casecmp'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [ipa_kdb_tests] Error 1
make[1]: Leaving directory `/home/remote/jhrozek/devel/freeipa/daemons/ipa-kdb'
make: *** [check-am] Error 2

The tests passes now:
Testsuite summary for ipa-server 4.0.0GIT2563ea2
============================================================================
# TOTAL: 1
# PASS:  1
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

Why don't the tests run at build time by default?