[Freeipa-devel] [PATCH] 0645 ipa-replica-prepare: Wait for the DNS entry to be resolvable

[Petr Viktorin]

On 09/24/2014 01:54 PM, Petr Spacek wrote:
> On 24.9.2014 13:47, Petr Viktorin wrote:
>> On 09/23/2014 06:00 PM, Petr Spacek wrote:
>>> On 22.9.2014 14:09, Petr Viktorin wrote:
>>>> On 09/22/2014 01:48 PM, Petr Spacek wrote:
>>>>> On 22.9.2014 10:38, Martin Kosek wrote:
>>>>>> On 09/22/2014 10:31 AM, Petr Spacek wrote:
>>>>>>> On 22.9.2014 10:14, Martin Kosek wrote:
>>>>>>>> On 09/19/2014 07:29 PM, Petr Viktorin wrote:
>>>>>>>>> https://fedorahosted.org/freeipa/ticket/4551
>>>>>>>>>
>>>>>>>>> See ticket & commit message for details.
>>>>>>>>
>>>>>>>> Shouldn't we add a 1 sec sleep between tries? Wouldn't current
>>>>>>>> version just
>>>>>>>> hammer DNS server with as many DNS queries as it can send?
>>>>>>>
[...]
>
> LGTM except one nitpick I didn't see before:
>
>> +        if not options.wait_for_dns or self.check_dns(replica_fqdn):
>> +            self.log.debug('%s A/AAAA record resolvable', replica_fqdn)
>> +            return
>
> This will print message
> '%s A/AAAA record resolvable', replica_fqdn
> even if I use switch --no-wait-for-dns
>
> This is sooo minor detail that it can be deferred, please open a ticket
> if you don't plan to send new version of the patch.

You're right.
Let's do it correctly now; this isn't worth the overhead of a ticket.

-- 
Petr³

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0645.4-ipa-replica-prepare-Wait-for-the-DNS-entry-to-be-res.patch
Type: text/x-patch
Size: 4127 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140924/669bda91/attachment.bin>