[Freeipa-devel] [PATCH] 755 webui-ci: case-insensitive record check
Endi Sukma Dewata
edewata at redhat.com
Wed Sep 24 14:16:52 UTC 2014
On 9/24/2014 8:26 AM, Petr Vobornik wrote:
> On 24.9.2014 04:43, Endi Sukma Dewata wrote:
>> On 9/22/2014 9:49 AM, Petr Vobornik wrote:
>>> [PATCH] webui-ci: case-insensitive record check
>>>
>>> Indirect association are no longer lower cased, which caused a issue
>>> in CI.
>>
>> Is the use of "|=" operator intentional? I don't see the "has" variable
>> defined anywhere else in this method.
>>
>> has |= self.has_record(pkey.lower(), parent, table_name)
>>
>> If this has been tested to work, then ACK.
>>
>
> it's defined on the previous line:
>
> has = self.has_record(pkey, parent, table_name)
> has |= self.has_record(pkey.lower(), parent, table_name)
Ah, I see. I thought the old line was being replaced.
ACK.
--
Endi S. Dewata
More information about the Freeipa-devel
mailing list