[Freeipa-devel] [PATCH] 755 webui-ci: case-insensitive record check
Petr Vobornik
pvoborni at redhat.com
Thu Sep 25 08:31:39 UTC 2014
On 24.9.2014 16:16, Endi Sukma Dewata wrote:
> On 9/24/2014 8:26 AM, Petr Vobornik wrote:
>> On 24.9.2014 04:43, Endi Sukma Dewata wrote:
>>> On 9/22/2014 9:49 AM, Petr Vobornik wrote:
>>>> [PATCH] webui-ci: case-insensitive record check
>>>>
>>>> Indirect association are no longer lower cased, which caused a issue
>>>> in CI.
>>>
>>> Is the use of "|=" operator intentional? I don't see the "has" variable
>>> defined anywhere else in this method.
>>>
>>> has |= self.has_record(pkey.lower(), parent, table_name)
>>>
>>> If this has been tested to work, then ACK.
>>>
>>
>> it's defined on the previous line:
>>
>> has = self.has_record(pkey, parent, table_name)
>> has |= self.has_record(pkey.lower(), parent, table_name)
>
> Ah, I see. I thought the old line was being replaced.
> ACK.
>
Pushed to:
master: dafdd68a6ed7030d7f7a153144b36443603e884f
ipa-4-1: c66b1ec8c81dc65e2807ab54bdb13957eaf55534
--
Petr Vobornik
More information about the Freeipa-devel
mailing list