[Freeipa-devel] [PATCH] 0637 upgradeinstance: Restore listeners on failure

[Petr Viktorin]

On 09/26/2014 11:46 AM, Martin Kosek wrote:
> On 09/25/2014 01:24 PM, Martin Kosek wrote:
>> On 09/24/2014 10:43 AM, Martin Kosek wrote:
>>> On 08/22/2014 06:07 PM, Petr Viktorin wrote:
>>>> https://fedorahosted.org/freeipa/ticket/4499
>>>>
>>>> Actually I wonder why we use backup_state/restore_state for these
>>>> settings.
>>>> Rob, was there a reason for not just always setting nsslapd-port:
>>>> 389 and
>>>> nsslapd-security: on?
>>>
>>> This works pretty nicely, I liked the service.py extension.
>>>
>>> My test output:
>>>
>>> # ipa-ldap-updater --upgrade
>>> Upgrading IPA:
>>>    [1/10]: stopping directory server
>>>    [2/10]: saving configuration
>>>    [3/10]: disabling listeners
>>>    [4/10]: starting directory server
>>>    [5/10]: preparing server upgrade
>>> PRE_SCHEMA_UPDATE
>>>    [6/10]: updating schema
>>> ...
>>>    [7/10]: upgrading server
>>>    [error] ValueError: Ha!
>>>    [cleanup]: stopping directory server
>>>    [cleanup]: restoring configuration
>>>
>>> # ipactl start
>>> # netstat -putna | grep 389
>>> ...
>>> tcp6       0      0 10.16.78.147:389        10.16.78.147:37490
>>> ESTABLISHED
>>> 5956/ns-slapd
>>>
>>> So I am willing to ACK if there are no other objections.
>>>
>>> Martin
>>
>> I read the silence as "no objections", so ACK.
>>
>> Pushed to:
>> master: 9a188607fcf68721fc8c38c3c73ee02cac76b58a
>> ipa-4-1: b333e7adc98ff7c5335fbc7ce1bde5b9dfb3f5ef
>>
>> Martin
>
> Just found (benign) display issue with this patch when --external-ca is
> used. See:
>
> https://fedorahosted.org/freeipa/ticket/4499#comment:4
>
> Martin

You're right. This patch should fix that.

-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0649-ipaserver.install.service-Don-t-show-error-message-o.patch
Type: text/x-patch
Size: 1847 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140926/20d9c203/attachment.bin>