[Freeipa-devel] [PATCH 023] Add flag to list all service and user vaults

[Jan Cholasta]

Hi,

On 19.8.2015 13:39, Christian Heimes wrote:
> The vault-find plugin has two additional arguments to list all
> service vaults or user vaults. Since the name of a vault is only unique
> for a particular user or service, the commands also print the vault user
> or vault service. The virtual attributes were added in rev
> 01dd951ddc0181b559eb3dd5ff0336c81e245628.
>
> Example:
>
> $ ipa vault-find --users
> ----------------
> 2 vaults matched
> ----------------
>    Vault name: myvault
>    Type: standard
>    Vault user: admin
>
>    Vault name: UserVault
>    Type: standard
>    Vault user: admin
> ----------------------------
> Number of entries returned 2
> ----------------------------
>
> $ ipa vault-find --services
> ----------------
> 2 vaults matched
> ----------------
>    Vault name: myvault
>    Type: standard
>    Vault service: HTTP/ipatest.freeipa.local at FREEIPA.LOCAL
>
>    Vault name: myvault
>    Type: standard
>    Vault service: ldap/ipatest.freeipa.local at FREEIPA.LOCAL
> ----------------------------
> Number of entries returned 2
> ----------------------------
>
> https://fedorahosted.org/freeipa/ticket/5150

The new flags should be handled in vault_find's pre_callback instead of 
vault's get_dn, as they are exclusive to vault_find and worse yet, 
conflict with vault_{add,remove}_{owner,member}'s flags, leading to 
unwanted behavior:

$ ipa vault-add-member --service testsvc/example.com testvault 
--services testsvc/example.com
ipa: ERROR: Service(s), shared, and user(s) options cannot be specified 
simultaneously

Honza

-- 
Jan Cholasta