[Freeipa-devel] [PATCHES] changes in preparation of replica promotion work

David Kupka dkupka at redhat.com
Thu Aug 27 11:43:57 UTC 2015


On 27/08/15 11:05, Jan Cholasta wrote:
> On 27.8.2015 07:56, Jan Cholasta wrote:
>> On 25.8.2015 20:43, Simo Sorce wrote:
>>> On Wed, 2015-08-05 at 11:24 -0400, Simo Sorce wrote:
>>>> On Wed, 2015-08-05 at 08:20 +0200, Jan Cholasta wrote:
>>>>> Hi,
>>>>>
>>>>> Dne 31.7.2015 v 12:46 Simo Sorce napsal(a):
>>>>>> I've been carrying these patches in my tree for a while, I think
>>>>>> it is
>>>>>> time to put them in master as they stand on their own.
>>>>>>
>>>>>> Simo.
>>>>>
>>>>> Patch 530: ACK
>>>>>
>>>>> Patch 531: ACK
>>>>>
>>>>> Patch 532:
>>>>>
>>>>> The methods should be static methods:
>>>>>
>>>>>       @staticmethod
>>>>>       def setOption(name, value):
>>>>>       ...
>>>>
>>>> Care to explain why ?
>>>> @staticmethod is not used anywhere else in that file.
>>>
>>> Rebased patches on master, made requested change +1 more patch.
>>>
>>> Simo.
>>>
>>
>> Patch 532: ACK
>>
>> Patch 533: ACK
>>
>> Pushed to master: f57b687241fbc92d1138507210e87e9de465c507
>>
>> Honza
>>
>
> Actually, there is a problem with patch 531: SASL mapping are added only
> on replica.
>
> The attached patch fixes it.
>
>
>
Works for me, ACK.

-- 
David Kupka




More information about the Freeipa-devel mailing list