[Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

Tomas Babej tbabej at redhat.com
Thu Dec 3 15:33:54 UTC 2015



On 12/03/2015 04:26 PM, Aleš Mareček wrote:
> Hello,
> 
> ACK for code
> NACK for the placing "get_client_ip_with_hostmask" function to test_sudo.py (this function should be in some more general file)
> 

What place would you propose? The task.py is not a good place, as this
is not really a task.

Nevertheless, I'd rather have it moved when an use case outside
test_sudo.py actually arises. Right now it would lead to unnecessary
cluttering.

Tomas




More information about the Freeipa-devel mailing list