[Freeipa-devel] [PATCHES 180-181] Fix forwardzone update

Petr Spacek pspacek at redhat.com
Fri Jan 9 12:17:52 UTC 2015


On 8.1.2015 16:53, Martin Basti wrote:
> On 08/01/15 16:42, Petr Spacek wrote:
>> On 7.1.2015 13:56, Martin Basti wrote:
>>> +        for config_option in container_entry.get("ipaConfigString", []):
>>> +            matched = re.match(r"^DNSVersion\s+(?P<version>%d)$",
>> %d is C-ishm which does not work
>>
>>> +                               config_option, flags=re.I)
>>> +            if matched and matched.group("version") >= 1:
>> group("version") should be converted to int before comparison
>>
>> Otherwise it seems that zone update itself works flawlessly for me.
>>
>> HUGE NACK :-D
>>
> Stupid me.
> Updated patches attached.

ACK

-- 
Petr^2 Spacek




More information about the Freeipa-devel mailing list