[Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

[Petr Vobornik]

On 01/13/2015 02:26 PM, Jan Cholasta wrote:
> Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a):
>> On 01/12/2015 02:28 PM, Jan Cholasta wrote:
>>> Hi,
>>>
>>> the attached patch fixes <https://fedorahosted.org/freeipa/ticket/4797>.
>>>
>>> Note that --data with data-only backup and --logs-only with data-only
>>> restore are deliberately ignored and considered no-op.
>>>
>>> Honza
>>>

>>
>> 3. When #2 fixed, data backup with --no-logs doesn't raise warning as
>> requested in ticket.
>
> IMO such a warning does not make sense. You request no logs, you get no
> logs, I don't see anything worth warning about here.

ok, makes sense

>
>>
>> 5. Nitpick: imho option validation should be done before temp dir
>> creation.
>
> Fixed.

You've also moved
   self.header = os.path.join(self.backup_dir, 'header')
below
   self.read_header()

--> restore fails everytime

>
> Updated patch attached.
>

-- 
Petr Vobornik