[Freeipa-devel] [PATCH] 0016 user life cycle: Display the wrong attribute name when mandatory attribute is missing

[Tomas Babej]

On 07/02/2015 10:34 AM, thierry bordaz wrote:
> On 07/01/2015 05:39 PM, Tomas Babej wrote:
>> Hi Thierry,
>>
>> I think it would be better to use:
>>
>> error=_('Entry has no \'%s\'') % attr
>>
>> or even better, use named substitution:
>>
>> error=_('Entry has no \'%(attribute)s\'') % dict(attribute=attr)
>>
>> This way will generate a more readable strings for translators.
>>
>> Tomas
> Hi Tomas,
> 
> Thanks for reviewing.. you are right this is the common way of adding
> values in the such error messages.
> I followed your recommendations
> 
> thanks
> thierry

Thanks!

ACK.

Pushed to master: b5cb95431bffd39475fa82a453ef057890425529