[Freeipa-devel] [PATCH] 0016 user life cycle: Display the wrong attribute name when mandatory attribute is missing

[thierry bordaz]

On 07/01/2015 05:39 PM, Tomas Babej wrote:
> Hi Thierry,
>
> I think it would be better to use:
>
> error=_('Entry has no \'%s\'') % attr
>
> or even better, use named substitution:
>
> error=_('Entry has no \'%(attribute)s\'') % dict(attribute=attr)
>
> This way will generate a more readable strings for translators.
>
> Tomas
Hi Tomas,

Thanks for reviewing.. you are right this is the common way of adding 
values in the such error messages.
I followed your recommendations

thanks
thierry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150702/626f0630/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbordaz-0016-1-Display-the-wrong-attribute-name-when-mandatory-attr.patch
Type: text/x-patch
Size: 1131 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150702/626f0630/attachment.bin>