[Freeipa-devel] [PATCH 0051] Clear SSSD caches when uninstalling the client

[Tomas Babej]

On 06/30/2015 05:40 PM, Simo Sorce wrote:
> On Tue, 2015-06-30 at 16:10 +0200, Martin Basti wrote:
>> On 30/06/15 15:18, Martin Basti wrote:
>>> On 30/06/15 14:47, Simo Sorce wrote:
>>>> On Tue, 2015-06-30 at 13:19 +0200, Tomas Babej wrote:
>>>>> On 06/30/2015 01:08 PM, Martin Basti wrote:
>>>>>> On 30/06/15 13:00, Tomas Babej wrote:
>>>>>>> On 06/29/2015 03:50 PM, Martin Basti wrote:
>>>>>>>> On 29/06/15 13:46, Jakub Hrozek wrote:
>>>>>>>>> On Fri, Jun 05, 2015 at 11:31:54AM -0600, Gabe Alford wrote:
>>>>>>>>>> Thanks. Updated patch attached.
>>>>>>>>>>
>>>>>>>>>> On Fri, Jun 5, 2015 at 9:53 AM, Jakub Hrozek <jhrozek at redhat.com>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> On Fri, Jun 05, 2015 at 09:46:05AM -0600, Gabe Alford wrote:
>>>>>>>>>>>> How should ​
>>>>>>>>>>>> https://www.redhat.com/archives/freeipa-users/2015-June/msg00116.html 
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> be
>>>>>>>>>>>> handled where the user cleared out the db cache?
>>>>>>>>>>> Ah, I confused that one with another issue Jan Pazdziora had,
>>>>>>>>>>> which was
>>>>>>>>>>> incidentally about client uninstall as well.
>>>>>>>>>>>
>>>>>>>>>>> In that case, you can just remove the single ldb file that
>>>>>>>>>>> corresponds
>>>>>>>>>>> to the domain that the client is leaving. Maybe it would be safer
>>>>>>>>>>> to mv
>>>>>>>>>>> the files instead of remove them, but I guess if you run 
>>>>>>>>>>> --uninstall,
>>>>>>>>>>> you really want just to purge everything..
>>>>>>>>>>>
>>>>>>>>>>> btw do the ipa installer tools support multiple domains at all?
>>>>>>>>>>>
>>>>>>>>>>> -- 
>>>>>>>>>>> Manage your subscription for the Freeipa-devel mailing list:
>>>>>>>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>>>>>>>>> Contribute to FreeIPA: 
>>>>>>>>>>> http://www.freeipa.org/page/Contribute/Code
>>>>>>>>>>>
>>>>>>>>>>    From 40f7c3780baaf0b42d10c94c8527c9359a42247f Mon Sep 17 
>>>>>>>>>> 00:00:00
>>>>>>>>>> 2001
>>>>>>>>>> From: Gabe <redhatrises at gmail.com>
>>>>>>>>>> Date: Fri, 5 Jun 2015 11:27:46 -0600
>>>>>>>>>> Subject: [PATCH] Clear SSSD caches when uninstalling the client
>>>>>>>>>>
>>>>>>>>>> https://fedorahosted.org/freeipa/ticket/5049
>>>>>>>>> Conceptually LGTM, but I haven't tested the patch.
>>>>>>>>>
>>>>>>>> ACK, I did testing.
>>>>>>>>
>>>>>>> Pushed to master: 37729936dd6fe9c3396cbb8a682a4674af8b5537
>>>>>>>
>>>>>>> For ipa-4-1 the patch requires a rebase.
>>>>>> Rebased patch for ipa-4-1 attached.
>>>>>>
>>>>> Pushed to ipa-4-1: 222427cb37a037f24ca76a9bcf614a2711a2ba96
>>>>>
>>>> This patch break ipa-client-install --uninstall when the first part of
>>>> sssd uninstall fails, and exception is thrown and we 'pass', but then
>>>> domain is not set and we use it.
>>>>
>>>> Please revert or fix it.
>>>>
>>>> Simo.
>>>>
>>> I will fix it.
>>>
>> Fix attached.
> 
> Tested on my server and it seem to work correctly.
> Code-wise also LGTM.
> 
> ACK.
> Simo.
> 

Pushed to master: 6fa123447f8acfbbdb442a1cbac38997a8e81208
Pushed to ipa-4-1: 56db66371eaa4995fa2a672663d9b8ff1520f63d