[Freeipa-devel] [PATCHES 145-148] ipa-kdb: add unit-test for filter_logon_info()

[Tomas Babej]

On 07/07/2015 03:49 PM, Sumit Bose wrote:
> On Tue, May 26, 2015 at 01:36:35PM +0200, Martin Kosek wrote:
>> On 05/26/2015 01:33 PM, Sumit Bose wrote:
>>> Hi,
>>>
>>> these patches add some unit tests and some additional improvements
>>> related to the issues described in
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1222475 . The original issue
>>> is fixed by a patch from Alexander attached to the ticket.
>>>
>>> The first patch converts the existing check-based test to cmocka. If I
>>> see it correctly all check-based test are converted now.
>>
>> Cool! Before pushing, we should also reference ticket
>> https://fedorahosted.org/freeipa/ticket/4922
>> in the patch (no need to rebase right now).
>>
>>>
>>> The second adds tests for filter_logon_info() where the original issue
>>> occurred. The wrong behavior in filter_logon_info() caused a crash in
>>> dom_sid_string() which is made a bit more robust together with
>>> string_to_sid() in the 3rd patch. The last patch add unit tests for
>>> those two calls as well.
> 
> New version rebased on one-way trust patches attached.
> 
> Please note that the unit-test will fail with the initial version of the
> one-way trust patches which does not allow an empty group list in the
> PAC.
> 
> bye,
> Sumit
> 
> 
> 

ACK.

Pushed to master: 5017726ebaf6eea3dedb1325efe00c0d6c4b6187

Tomas