[Freeipa-devel] Meaning of two strings in plugins/service.py

[Jérôme Fenal]

2015-07-08 9:45 GMT+02:00 Petr Vobornik <pvoborni at redhat.com>:
> On 07/08/2015 09:31 AM, David Kupka wrote:
>>
>> On 05/07/15 11:25, Jérôme Fenal wrote:
>>>
>>> Hi,
>>>
>>> I stumbled upon those two following strings while translating into
>>> French, and just cannot figure out the meaning.
>>>
>>>      Str('ipaallowedtoperform_read_keys',
>>>          label=_('Failed allowed to retrieve keytab'),
>>>      ),
>>>      Str('ipaallowedtoperform_write_keys',
>>>          label=_('Failed allowed to create keytab'),
>>>      ),
>>>
>>> Would it be that failure is allowed while retrieving or creating keytab?
>>> Or...?
>>>
>>> Thanks for helping,
>>>
>>> Jérôme
>>>
>>
>> Hi Jérôme,
>> I guess it should be "Failed to allow retrieval/creation of keytab".
>> But Petr (added) is author of this code and should know better.
>>
>
> It's used in a following way (user abc does not exist):
>
> ipa host-allow-create-keytab vm-121.example.com --users=abc
>   Host name: vm-121.example.com.com
>   Principal name: host/vm-121.example.com at EXAMPLE.COM
>   Managed by: vm-121.example.com.com
>   Failed allowed to create keytab:
>     member user: abc: no such entry
>     member group:
>     member host:
>     member host group:
> -------------------------
> Number of members added 0
> -------------------------
>
> I.e., host groups, hosts, user groups, users  who were not added as the ones
> who are allowed to to retrieve/create keytab.

So I guess it'd be more "Failed to allow retrieval/creation of keytab".

Should I propose a patch to change the sentence?

Regards,

J.

-- 
Jérôme Fenal