[Freeipa-devel] [PATCH 0339] trusts: Check for AD root domain among our trusted domains

[Tomas Babej]

On 07/15/2015 02:31 PM, Alexander Bokovoy wrote:
> On Wed, 15 Jul 2015, Tomas Babej wrote:
>> Hi,
>>
>> Check for the presence of the forest root DNS domain of the AD realm
>> among the IPA realm domains prior to esablishing the trust.
>>
>> This prevents creation of a failing setup, as trusts would not work
>> properly in this case.
>>
>> https://fedorahosted.org/freeipa/ticket/4799
> LGTM.
> 
> The only comment I have is for the error message text. Would it make
> sense to point to 'ipa realmdomans-mod --del-domain' command?
> 
> 

Sure, why not.

I actually abstained from generating the whole command (including the AD
domain argument), as I believe it's better the users are discouraged
from blindly copying commands around.

Updated patch attached.

Toams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0339-2-trusts-Check-for-AD-root-domain-among-our-trusted-do.patch
Type: text/x-patch
Size: 2632 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150715/3e767755/attachment.bin>