[Freeipa-devel] [PATCH 0023] enable debugging of spawned ntpd command during client install

[Jan Cholasta]

Dne 20.7.2015 v 14:11 Martin Basti napsal(a):
> On 14/07/15 12:19, Martin Babinsky wrote:
>> On 03/30/2015 12:38 PM, Martin Babinsky wrote:
>>> On 03/26/2015 01:14 PM, Martin Kosek wrote:
>>>> On 03/25/2015 04:18 PM, Jan Cholasta wrote:
>>>>> Hi,
>>>>>
>>>>> Dne 25.3.2015 v 15:26 Martin Babinsky napsal(a):
>>>>>> The attached patch related to
>>>>>> https://fedorahosted.org/freeipa/ticket/4931
>>>>>
>>>>> Please make sure <https://fedorahosted.org/freeipa/ticket/3048> stays
>>>>> fixed.
>>>>>
>>>>>>
>>>>>> It is certainly not a final solution, more of an initial "hack" of
>>>>>> sorts
>>>>>> just to gather some suggestions, since I am not even sure if this is
>>>>>> the
>>>>>> right thing to do.
>>>>>>
>>>>>> The reporter from bugzilla suggests to enable debugging of ALL
>>>>>> commands
>>>>>> called through ipautil.run(), but I think that fixing all cca 157
>>>>>> found
>>>>>> usages of run() is too much work with a quite small benefit.
>>>>>>
>>>>>> Anyway I would welcome some opinions about this: should the external
>>>>>> commands really inherit the debug settings of ipa-* utilities, and if
>>>>>> so, is the method showed in this patch the right way to do it?
>>>>>
>>>>> I am not a fan of this method, ipautil.run does not know anything
>>>>> about the
>>>>> command it runs and I think it should stay that way.
>>>>>
>>>>> I would prefer to have an ipautil.run wrapper with debug flag using
>>>>> appropriate
>>>>> debugging option for each command where we need to conditionally
>>>>> enable
>>>>> debugging. Or just add the debugging option unconditionally to every
>>>>> command
>>>>> where it could be useful.
>>>>
>>>> +1, I do not like this change to ipautil.run either. It should be sole
>>>> responsibility of the caller to specify the right combinations of
>>>> options,
>>>> including debug option, where applicable.
>>>>
>>> Attaching updated patch.
>>>
>>>
>>>
>> Reviving this patch from the dead. Attaching rebased version for
>> master branch and ipa-4-1.
>>
>>
>>
> Works for me, ACK

Pushed to:
master: 1ec174b92d2a734bd5859689bc67de5974270b06
ipa-4-2: a637e21d8810f14cbc4d212f13206fc08dfd1f86
ipa-4-1: bd1e3146c42c5c36e5a19b7558d268a823d45e0c

-- 
Jan Cholasta