[Freeipa-devel] variable name 'rsa_public_key' in vault

[Christian Heimes]

Hello,

while I was working on https://fedorahosted.org/freeipa/ticket/5142 and
patch 019, I noticed the variable names rsa_public_key and
rsa_private_key in vault.py. load_pem_public_key() can load and return
other key formats (DSA, ECDSA), too. Does vault mean to support the
other algorithms?

In case vault should support any kind of asymmetric cipher, I'd like to
change the variable names. It's confusing. Otherwise we should add a
check for RSA and prevent DSA and ECDSA keys.

Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150724/32cc0bc8/attachment.sig>