[Freeipa-devel] [PATCH 0050] ACI plugin: correctly parse bind rules enclosed in parentheses

Martin Basti mbasti at redhat.com
Tue Jul 28 12:11:38 UTC 2015


On 28/07/15 13:33, Martin Babinsky wrote:
> On 07/27/2015 05:10 PM, Martin Basti wrote:
>> On 23/07/15 16:06, Martin Babinsky wrote:
>>> This is a quick fix for https://fedorahosted.org/freeipa/ticket/5037
>>>
>>>
>>>
>> NACK
>>
>> I do not like your change in first regexp too much.
>>
>> Can you try this instead?
>>
>> PermPat = re.compile(r'(\w+)\s*\(([^()]*)\)\s*(.*)', re.UNICODE)
>>
>> This just removes '(' and ') ' from pattern and accept all other 
>> characters.
>>
>> -- 
>> Martin Basti
>>
>
> Attaching updated patch.
>
ACK

-- 
Martin Basti




More information about the Freeipa-devel mailing list