[Freeipa-devel] [PATCH 0048] fix ipa help command output errors

[Jan Cholasta]

Dne 25.5.2015 v 14:27 Martin Basti napsal(a):
> On 22/05/15 17:40, Gabe Alford wrote:
>> On Fri, May 22, 2015 at 9:01 AM, Martin Basti <mbasti at redhat.com
>> <mailto:mbasti at redhat.com>> wrote:
>>
>>     On 22/05/15 16:08, Gabe Alford wrote:
>>>     Hello,
>>>
>>>     This should fix https://fedorahosted.org/freeipa/ticket/3584, and
>>>     as requested in the ticket, this should also fix
>>>     https://fedorahosted.org/freeipa/ticket/2284
>>>
>>>     Thanks,
>>>
>>>     Gabe
>>>
>>>
>>     Thank you!
>>
>>     IMO your first part of fix only mask issue, not solving it.
>>
>>     This could be way, but I did not test it.
>>
>>                 out_encoding = getattr(outfile, 'encoding', None)
>>                 if out_encoding is None:
>>                     out_encoding = 'utf-8'
>>                 print >> outfile, unicode(string).encode(out_encoding)
>>
>>
>> I'm confused and maybe missing something here. If I run `ipa help dns
>> | bad_command`, shouldn't the command fail with only the following?
>> -bash: bad: command not found
>>
>>
>>     Can you split this patch into 2 separate patches for each ticket
>>     please?
>>
>>
>> Done
>>
>>     Martin^2
>>
>>     --
>>     Martin Basti
>>
>>
> Thank you!
> ACK and ACK.

Pushed to master: b98077ea6844eddd8810e4ae6ddd5bf40c61b58e

-- 
Jan Cholasta