[Freeipa-devel] [PATCH 0006-0010] Low hanging fruit for #5343 -- platform abstractions

[Tomas Babej]

On Wed, Oct 07, 2015 at 12:51:10PM +0200, Tomas Babej wrote:
> On Tue, Oct 06, 2015 at 09:58:04PM +0300, Timo Aaltonen wrote:
> > 
> > 	Hi
> > 
> >   So here's the first batch of quick patches for ticket #5343. They're
> > only compile-tested so far (so no stupid mistakes I hope), as I don't
> > have 4.2+ working yet. Wonder how the quotes in the last patch work, but
> > at least make-lint didn't laugh too hard..
> > 
> > -- 
> > t
> 
> Hi,
> 
> overall this looks good, couple of comments inline.
> 

Additionally, there are some legitimate lint failures:

************* Module ipaserver.install.ntpinstance
ipaserver/install/ntpinstance.py:28: [E1101(no-member), ] Instance of
'FedoraConstantsNamespace' has no 'NTPD_OPTS_VAR' member)
ipaserver/install/ntpinstance.py:29: [E1101(no-member), ] Instance of
'FedoraConstantsNamespace' has no 'NTPD_OPTS_QUOTE' member)
************* Module ipaserver.install.httpinstance
ipaserver/install/httpinstance.py:252: [E1101(no-member),
HTTPInstance.__add_include] Instance of 'FedoraPathNamespace' has no
'HTTPD_CONF_D' member)

"NTPD*" vars are defined as "NTP*" in the Namespace and HTTPD_CONF_D
should be HTTPD_CONF_D_DIR.

HTH,

Tomas