[Freeipa-devel] [PATCH 0088-0095] Add --forward-policy option into installers

[Petr Spacek]

On 31.3.2016 13:45, Martin Basti wrote:
> 
> 
> On 21.03.2016 16:51, Petr Spacek wrote:
>> On 10.3.2016 22:17, Lukas Slebodnik wrote:
>>> On (10/03/16 22:14), Petr Spacek wrote:
>>>> Hello,
>>>>
>>>> I forgot to send a patches before I leave, so here it is:
>>>>
>>>> Auto-detect default value for --forward-policy option in installers
>>>>
>>>> See
>>>> https://fedorahosted.org/freeipa/ticket/5710
>>>> commit messages, and design page
>>>> https://fedorahosted.org/bind-dyndb-ldap/wiki/BIND9/Design/AutomaticEmptyZones
>>>>
>>>>
>>>>
>>>> I did not have time to test it thoroughly but it LGTM :-D
>>>>
>>>> Please note that this is first part, it does not solve upgrade (yet) and
>>>> warnings in forwardzone-* interface.
>>>>
>>>> This can be solved in another patch set, this can be pushed if it passes
>>>> review.
>>>>
>>> ENOPATH
>> LOL, here it is.
>>
>>
>>
>  * Remove function ipapython.ipautil.host_exists() *
> ACK
> 
> 
> * Extend installers with --forward-policy option *
> 1)
> There is no --forward-policy option in ipa-dns-install
> 
> 
> * Move automatic empty zone list into ipapython.dnsutil and make it reusable *
> ACK
> 
> 
> * Add assert_absolute_dnsname() helper to ipapython.dnsutil *
> ACK
> 
> 
> * Move function is_auto_empty_zone() into ipapython.dnsutil *
> ACK
> 
> 
> * Use shared sanity check and tests ipapython.dnsutil.is_auto_empty_zone() *
> ACK
> 
> * Add function ipapython.dnsutil.inside_auto_empty_zone() *
> ACK
> 
> * Auto-detect default value for --forward-policy option in installers *
> LGTM, but ipa-dns-install is missing option --forward-policy
> 
> # ipa-dns-install
> ...
> Unexpected error - see /var/log/ipaserver-install.log for details:
> AttributeError: Values instance has no attribute 'forward_policy'
> 
> 
> Summary: 6 ACKs, 1 LGTM, 1 NACK => NACK

Thank you very much for review.

Here is my second attempt :-)

-- 
Petr^2 Spacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0088-2-Remove-function-ipapython.ipautil.host_exists.patch
Type: text/x-patch
Size: 2546 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160404/6c0c6f60/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0089-2-Extend-installers-with-forward-policy-option.patch
Type: text/x-patch
Size: 9143 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160404/6c0c6f60/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0090-2-Move-automatic-empty-zone-list-into-ipapython.dnsuti.patch
Type: text/x-patch
Size: 8307 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160404/6c0c6f60/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0091-2-Add-assert_absolute_dnsname-helper-to-ipapython.dnsu.patch
Type: text/x-patch
Size: 1574 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160404/6c0c6f60/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0092-2-Move-function-is_auto_empty_zone-into-ipapython.dnsu.patch
Type: text/x-patch
Size: 2212 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160404/6c0c6f60/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0093-2-Use-shared-sanity-check-and-tests-ipapython.dnsutil..patch
Type: text/x-patch
Size: 1299 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160404/6c0c6f60/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0094-2-Add-function-ipapython.dnsutil.inside_auto_empty_zon.patch
Type: text/x-patch
Size: 1508 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160404/6c0c6f60/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0095-2-Auto-detect-default-value-for-forward-policy-option-.patch
Type: text/x-patch
Size: 6542 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160404/6c0c6f60/attachment-0007.bin>