[Freeipa-devel] [TESTS][PATCH] Ping module tests in a non-declarative way

[Martin Basti]

On 08.04.2016 10:32, Peter Lacko wrote:
>
>

Hello,

I have a few comments:

1)
Please set up your git name and email correctly (consistently for all 
patches)

this is not right From: root<root at vm-058-184.abc.idm.lab.eng.brq.redhat.com>

2)
-# Copyright (C) 2012  Red Hat
+# Copyright (C) 2016  Red Hat

leave there both years please
+# Copyright (C) 2012, 2016  Red Hat

3)
Please put the patch number to the email subject, it is easier to find correct patch for us

Otherwise LGTM and works for me.

Martin^2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160428/17332162/attachment.htm>