[Freeipa-devel] [PATCH 687] client: add missing output params to client-side commands

[Alexander Bokovoy]

On Wed, 10 Aug 2016, Jan Cholasta wrote:
>Hi,
>
>the attached patch fixes <https://fedorahosted.org/freeipa/ticket/6182>.
>
>Honza
>
>-- 
>Jan Cholasta

>From 2f21d1eee2ea2e3cc568b75bd32f24d7188cbe59 Mon Sep 17 00:00:00 2001
>From: Jan Cholasta <jcholast at redhat.com>
>Date: Wed, 10 Aug 2016 09:02:47 +0200
>Subject: [PATCH] client: add missing output params to client-side commands
>
>Add output params for the otptoken-add-yubikey, vault-add, vault-mod,
>vault-archive and vault-retrieve commands.
>
>This fixes the commands not having any output in CLI.
>
>https://fedorahosted.org/freeipa/ticket/6182
>---
> ipaclient/plugins/otptoken_yubikey.py |  6 ++++++
> ipaclient/plugins/vault.py            | 24 ++++++++++++++++++++++++
> 2 files changed, 30 insertions(+)
>
>diff --git a/ipaclient/plugins/otptoken_yubikey.py b/ipaclient/plugins/otptoken_yubikey.py
>index bfa244c..549376a 100644
>--- a/ipaclient/plugins/otptoken_yubikey.py
>+++ b/ipaclient/plugins/otptoken_yubikey.py
>@@ -106,6 +106,12 @@ class otptoken_add_yubikey(Command):
>         for option in super(otptoken_add_yubikey, self).get_options():
>             yield option
> 
>+    def get_output_params(self):
>+        for param in self.api.Command.otptoken_add.output_params():
>+            yield param
>+        for param in super(otptoken_add_yubikey, self).get_output_params():
>+            yield param
>+
>     def _iter_output(self):
>         return self.api.Command.otptoken_add.output()
> 
>diff --git a/ipaclient/plugins/vault.py b/ipaclient/plugins/vault.py
>index 1e715fd..c0ded21 100644
>--- a/ipaclient/plugins/vault.py
>+++ b/ipaclient/plugins/vault.py
>@@ -223,6 +223,12 @@ class vault_add(Local):
>         for option in super(vault_add, self).get_options():
>             yield option
> 
>+    def get_output_params(self):
>+        for param in self.api.Command.vault_add_internal.output_params():
>+            yield param
>+        for param in super(vault_add, self).get_output_params():
>+            yield param
>+
>     def _iter_output(self):
>         return self.api.Command.vault_add_internal.output()
> 
>@@ -423,6 +429,12 @@ class vault_mod(Local):
>         for option in super(vault_mod, self).get_options():
>             yield option
> 
>+    def get_output_params(self):
>+        for param in self.api.Command.vault_mod_internal.output_params():
>+            yield param
>+        for param in super(vault_mod, self).get_output_params():
>+            yield param
>+
>     def _iter_output(self):
>         return self.api.Command.vault_mod_internal.output()
> 
>@@ -607,6 +619,12 @@ class vault_archive(Local):
>         for option in super(vault_archive, self).get_options():
>             yield option
> 
>+    def get_output_params(self):
>+        for param in self.api.Command.vault_archive_internal.output_params():
>+            yield param
>+        for param in super(vault_archive, self).get_output_params():
>+            yield param
>+
>     def _iter_output(self):
>         return self.api.Command.vault_archive_internal.output()
> 
>@@ -855,6 +873,12 @@ class vault_retrieve(Local):
>         for option in super(vault_retrieve, self).get_options():
>             yield option
> 
>+    def get_output_params(self):
>+        for param in self.api.Command.vault_retrieve_internal.output_params():
>+            yield param
>+        for param in super(vault_retrieve, self).get_output_params():
>+            yield param
>+
>     def _iter_output(self):
>         return self.api.Command.vault_retrieve_internal.output()
> 
ACK.

-- 
/ Alexander Bokovoy