[Freeipa-devel] [PATCHES 681-682] cert: speed up cert-find, do not crash on invalid data in cert-find

[Martin Basti]

On 01.08.2016 10:27, Jan Cholasta wrote:
> On 1.8.2016 10:19, Jan Cholasta wrote:
>> Hi,
>>
>> the attached patches fix <https://fedorahosted.org/freeipa/ticket/6098>
>> and <https://fedorahosted.org/freeipa/ticket/6150>.
>
> Self-NACK, proper patches attached.
>
> Honza
>
>
>

IMHO this is caused by your patches, test_cert_plugin.py:

[Thu Aug 11 14:12:18.740950 2016] [wsgi:error] [pid 85941] ipa: ERROR: 
non-public: KeyError: 'owner'
[Thu Aug 11 14:12:18.740986 2016] [wsgi:error] [pid 85941] Traceback 
(most recent call last):
[Thu Aug 11 14:12:18.740988 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipaserver/rpcserver.py", line 359, in 
wsgi_execute
[Thu Aug 11 14:12:18.740990 2016] [wsgi:error] [pid 85941] result = 
self.Command[name](*args, **options)
[Thu Aug 11 14:12:18.740992 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 449, in __call__
[Thu Aug 11 14:12:18.740994 2016] [wsgi:error] [pid 85941] return 
self.__do_call(*args, **options)
[Thu Aug 11 14:12:18.740995 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 477, in 
__do_call
[Thu Aug 11 14:12:18.740997 2016] [wsgi:error] [pid 85941]     ret = 
self.run(*args, **options)
[Thu Aug 11 14:12:18.740998 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 799, in run
[Thu Aug 11 14:12:18.741000 2016] [wsgi:error] [pid 85941] return 
self.execute(*args, **options)
[Thu Aug 11 14:12:18.741001 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipaserver/plugins/baseldap.py", line 
1571, in execute
[Thu Aug 11 14:12:18.741003 2016] [wsgi:error] [pid 85941] 
delete_entry(pkey)
[Thu Aug 11 14:12:18.741004 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipaserver/plugins/baseldap.py", line 
1524, in delete_entry
[Thu Aug 11 14:12:18.741014 2016] [wsgi:error] [pid 85941]     dn = 
callback(self, ldap, dn, *nkeys, **options)
[Thu Aug 11 14:12:18.741016 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipaserver/plugins/host.py", line 794, 
in pre_callback
[Thu Aug 11 14:12:18.741018 2016] [wsgi:error] [pid 85941] 
api.Command['service_del'](principal)
[Thu Aug 11 14:12:18.741019 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 449, in __call__
[Thu Aug 11 14:12:18.741021 2016] [wsgi:error] [pid 85941] return 
self.__do_call(*args, **options)
[Thu Aug 11 14:12:18.741022 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 477, in 
__do_call
[Thu Aug 11 14:12:18.741024 2016] [wsgi:error] [pid 85941]     ret = 
self.run(*args, **options)
[Thu Aug 11 14:12:18.741025 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 799, in run
[Thu Aug 11 14:12:18.741027 2016] [wsgi:error] [pid 85941] return 
self.execute(*args, **options)
[Thu Aug 11 14:12:18.741028 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipaserver/plugins/baseldap.py", line 
1571, in execute
[Thu Aug 11 14:12:18.741029 2016] [wsgi:error] [pid 85941] 
delete_entry(pkey)
[Thu Aug 11 14:12:18.741031 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipaserver/plugins/baseldap.py", line 
1524, in delete_entry
[Thu Aug 11 14:12:18.741032 2016] [wsgi:error] [pid 85941]     dn = 
callback(self, ldap, dn, *nkeys, **options)
[Thu Aug 11 14:12:18.741034 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipaserver/plugins/service.py", line 
674, in pre_callback
[Thu Aug 11 14:12:18.741035 2016] [wsgi:error] [pid 85941] 
revoke_certs(entry_attrs.get('usercertificate', []), self.log)
[Thu Aug 11 14:12:18.741037 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipaserver/plugins/service.py", line 
230, in revoke_certs
[Thu Aug 11 14:12:18.741038 2016] [wsgi:error] [pid 85941] result = 
api.Command['cert_show'](unicode(serial))['result']
[Thu Aug 11 14:12:18.741040 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 449, in __call__
[Thu Aug 11 14:12:18.741041 2016] [wsgi:error] [pid 85941] return 
self.__do_call(*args, **options)
[Thu Aug 11 14:12:18.741042 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 477, in 
__do_call
[Thu Aug 11 14:12:18.741044 2016] [wsgi:error] [pid 85941]     ret = 
self.run(*args, **options)
[Thu Aug 11 14:12:18.741045 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 799, in run
[Thu Aug 11 14:12:18.741047 2016] [wsgi:error] [pid 85941] return 
self.execute(*args, **options)
[Thu Aug 11 14:12:18.741048 2016] [wsgi:error] [pid 85941]   File 
"/usr/lib/python2.7/site-packages/ipaserver/plugins/cert.py", line 792, 
in execute
[Thu Aug 11 14:12:18.741050 2016] [wsgi:error] [pid 85941]     del 
result['owner']
[Thu Aug 11 14:12:18.741051 2016] [wsgi:error] [pid 85941] KeyError: 'owner'

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160811/6f457a75/attachment.htm>