[Freeipa-devel] [PATCH 0003][Tests] Fix for integration tests replication layouts

[Ganna Kaihorodova]

Hello!

Thank you for review
Attached fixed patch

Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer


----- Original Message -----
From: "Martin Basti" <mbasti at redhat.com>
To: "Ganna Kaihorodova" <gkaihoro at redhat.com>, "freeipa-devel" <freeipa-devel at redhat.com>
Sent: Thursday, August 11, 2016 11:00:21 AM
Subject: Re: [Freeipa-devel] [PATCH 0003][Tests] Fix for integration tests replication layouts



On 09.08.2016 16:55, Ganna Kaihorodova wrote:
> Hello!
>
> Domain level 0 doesn't allow to create replica file on CA master, testcase was skipped with Domain level 0
>
> https://fedorahosted.org/freeipa/ticket/6134
>
> Best regards,
> Ganna Kaihorodova
> Associate Software Quality Engineer
>
>
>
>
Hello,

Please fix PEP8 error you introduced.
./ipatests/test_integration/test_replication_layouts.py:32:1: E302 
expected 2 blank lines, found 1

IMO this need skip on domain level 0 too
* Test2ConnectedTopologyWithoutCA
* TestDoubleCircleTopologyWithoutCA

Martin^2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-gkaihoro-0003-2-Fix-for-integration-tests-replication-layouts.patch
Type: text/x-patch
Size: 2190 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160812/56c8a001/attachment.bin>