[Freeipa-devel] [PATCH 0004] [Test] Test for caacl-add-service: incorrect error message when service does not exists

Tomas Krizek tkrizek at redhat.com
Thu Aug 18 13:02:03 UTC 2016


Hi,

NACK.

The issue is not that the error message contains the "no such entry" 
string. That is actually a valid part of the error message if the 
service indeed does not exist.

The problem is that the error message contained only the first character 
of the service's name instead of the entire name of the service. For 
example, the command

ipa caacl-add-service test_caacl --services svc/master2.ipa.test --services svc/master1.ipa.test

should end with these error messages if those services do not exist:

     member service: svc/master2.ipa.test at IPA.TEST: no such entry
     member service: svc/master1.ipa.test at IPA.TEST: no such entry

There is also a typo in the file name of the test and I'm also not sure if there isn't a better place to put the test.

On 08/18/2016 01:48 PM, Ganna Kaihorodova wrote:
> Hello!
>
> Test for caacl-add-service: incorrect error message when service does not exists
> https://fedorahosted.org/freeipa/ticket/6171
>
> Best regards,
> Ganna Kaihorodova
> Associate Software Quality Engineer
>
>
> :
>
>

-- 
Tomas Krizek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160818/ffd71ad2/attachment.htm>


More information about the Freeipa-devel mailing list