[Freeipa-devel] [PATCH 689] tests: fix test_ipalib.test_frontend.test_Object

Jan Cholasta jcholast at redhat.com
Mon Aug 22 05:48:30 UTC 2016


On 18.8.2016 11:01, Martin Basti wrote:
>
>
> On 18.08.2016 10:56, Petr Spacek wrote:
>> On 18.8.2016 10:08, Jan Cholasta wrote:
>>> SSIA
>> Could you add one sentence or a link to a ticket which forced this
>> change?
>>
>> When reading the patch, I have no way to say why the change is
>> necessary - so
>> it is impossible to verify correctness. (Sure, the test will pass, but
>> I have
>> no way to distinguish incorrect test passing on incorrect
>> implementation vs.
>> correct test passing on correct implementation.)
>>
> +1
>
> and add there this link also https://fedorahosted.org/freeipa/ticket/6188

Updated patch attached.

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-689.1-tests-fix-test_ipalib.test_frontend.test_Object.patch
Type: text/x-patch
Size: 2011 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160822/32e23578/attachment.bin>


More information about the Freeipa-devel mailing list