[Freeipa-devel] [PATCH] 0024 memory leak in ipapwd plugin

[Martin Basti]

On 11.08.2016 16:39, Alexander Bokovoy wrote:
> On Thu, 11 Aug 2016, thierry bordaz wrote:
>>>> +        /* rc should always be 0 (else slapi_sdn_new_dn_byref 
>>>> should have sigsev)
>>>> +         * but if we end in rc==LDAP_OPERATIONS_ERROR be sure to 
>>>> stop here
>>>> +         * because ret is not significant */
>>> A short note here. You talk about slapi_sdn_new_dn_byref() but your
>>> patch replaces that with slapi_sdn_new_dn_byval(). Does the comment
>>> still apply?
>>>
>>>> +        if (rc != 0) {
>>>> +            LOG_OOM();
>>>> +            goto free_and_return;
>>>> +        }
>>>> +
>>>>        if (ret == 0) {
>>>>            Slapi_Value *cpw[2] = { NULL, NULL };
>>>>            Slapi_Value *pw;
>>>> -- 
>>>> 2.7.4
>>>>
>>>
>>>
>> Good catch Alexander. Yes the comment contained a wrong cut/paste
> ACK.
>
>
Is there a ticket for this?