[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA
pspacek
freeipa-github-notification at redhat.com
Fri Dec 9 14:45:18 UTC 2016
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
pspacek commented:
"""
Guys, I'm confused. What exactly is the purpose of `TokenGenerator`? The docstring does not explain to me what is relation between arguments in `__init__` and `__call__`. Of course I can guess but this should be clearly defined first.
If we are clever enough we can get away with the `while` loop and make it deterministic.
"""
See the full comment at https://github.com/freeipa/freeipa/pull/317#issuecomment-266030088
More information about the Freeipa-devel
mailing list