[Freeipa-devel] [PATCH 0128] ipalib/cli.py: pythonify Collector class

[Martin Babinsky]

On 01/28/2016 03:20 PM, Tomas Babej wrote:
>
>
> On 01/27/2016 03:58 PM, Martin Babinsky wrote:
>> On 01/18/2016 06:43 PM, Martin Babinsky wrote:
>>> A little patch that should make some future pylint errors disappear.
>>>
>>>
>>>
>> Attaching updated patch that does not promote direct molestation of
>> instance dictionaries.
>>
>>
>>
>
> Patch looks good, one thing I am concerened about though is that
> __todict__ now returns a direct reference to the internal, mutable dict,
> and no longer a (shallow) copy.
>
> Maybe we should use dict.copy() there?
>
> Tomas
>

Ah I didn't realize that. Fixed in updated patch.

-- 
Martin^3 Babinsky
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbabinsk-0128.2-ipalib-cli.py-pythonify-Collector-class.patch
Type: text/x-patch
Size: 1810 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160128/45f366a2/attachment.bin>