[Freeipa-devel] [PATCH 0552] Vault: enable client side plugins CLI

[Jan Cholasta]

Hi,

On 12.7.2016 16:03, Petr Vobornik wrote:
> On 07/12/2016 02:06 PM, Martin Babinsky wrote:
>> On 07/08/2016 04:36 PM, Alexander Bokovoy wrote:
>>> On Fri, 08 Jul 2016, Martin Basti wrote:
>>>> Patch attached.
>>>> https://fedorahosted.org/freeipa/ticket/6035
>>>
>>>> From 2c97c316c1db49daeda15c709f082ee083a741ad Mon Sep 17 00:00:00 2001
>>>> From: Martin Basti <mbasti at redhat.com>
>>>> Date: Fri, 8 Jul 2016 15:53:25 +0200
>>>> Subject: [PATCH] Enable vault-* commands on client
>>>>
>>>> Client plugins fot vault commands were disabled by NO_CLI=True,
>>>> inherited from vault_add_interal, that is always NO_CLI=True.
>>>> Introduced by this commit 8278da6967dbe425b4e0c6cf37dc1c53052525b2
>>>>
>>>> Removed NO_CLI=True from client side plugins for vault.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/6035
>>> ACK.
>>>
>>> I haven't tested it but the change is obvious.
>>>
>>
>> And it works as expected, so ACK also from me.
>>
>
> master:
> * 9feeaca9fb552229638ce98086aa75905a45b48d Enable vault-* commands on client

The intent of the NO_CLI properties was to hide the commands when the 
server does not support them. It didn't exactly work for vault commands, 
but must be done anyway.

Ticket: <https://fedorahosted.org/freeipa/ticket/6089>

Honza

-- 
Jan Cholasta