[Freeipa-devel] [PATCH] 963 unite log file name of ipa-ca-install

Jan Cholasta jcholast at redhat.com
Tue Jul 19 06:01:02 UTC 2016


Hi,

On 18.7.2016 18:50, Florence Blanc-Renaud wrote:
> On 07/15/2016 04:29 PM, Petr Vobornik wrote:
>> ipa-ca-install said that it used
>>   /var/log/ipareplica-ca-install.log
>> but in fact it used
>>   /var/log/ipaserver-ca-install.log
>>
>> This patch unites it to ipaserver-ca-install.log
>>
>> It was chosen because ipa-ca-install can be also used on
>> master on CA-less -> CA conversion.
>>
>> Term "server" is valid for both master and replica.
>>
>> https://fedorahosted.org/freeipa/ticket/6088
>>
>>
>>
>
> Looks good to me.
> Ack

Does not look so good to me, "ipareplica-ca-install.log" is in fact the 
original file name used since ipa-ca-install was introduced (in commit 
8a32bb3746802a29b2655e4ad2cbbba8481e1eaf), so why the switch to 
"ipaserver-ca-install.log"?

Honza

-- 
Jan Cholasta




More information about the Freeipa-devel mailing list