[Freeipa-devel] [PATCH 0150] replica-install: Fix --domain

[Jan Cholasta]

On 28.7.2016 16:53, Petr Spacek wrote:
> On 28.7.2016 16:39, Jan Cholasta wrote:
>> On 25.7.2016 16:36, Petr Spacek wrote:
>>> On 25.7.2016 16:16, Jan Cholasta wrote:
>>>> On 25.7.2016 15:55, Petr Spacek wrote:
>>>>> Hello,
>>>>>
>>>>> replica-install: Fix --domain
>>>>>
>>>>> Replica installation must not check existence of --domain - the domain
>>>>> must (logically) exist.
>>>>>
>>>>> https://fedorahosted.org/freeipa/ticket/6130
>>>>
>>>> Note that Server.domain_name is already defined on line 1204 in
>>>> ipaserver/install/server/install.py.
>>>
>>> My bad, here is updated patch.
>>
>> Please use the original domain_name definition in Server, the order of knobs
>> in the class matters.
>
> Ah, the order in class is re-used for ordering in --help.
>
> Given that --domain option depends on setup_dns which is defined before, I had
> to move realm option down so realm & domain are next to each other.

Right. Works for me, ACK.

Pushed to master: 6eb9eb730350937692a442b66e4d79d3ebd4eb01

-- 
Jan Cholasta