[Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

[Pavel Vomacka]

On 06/02/2016 06:22 PM, Petr Vobornik wrote:
> On 06/01/2016 10:41 AM, Pavel Vomacka wrote:
>>
>> On 05/27/2016 05:58 PM, Pavel Vomacka wrote:
>>>
>>> On 05/27/2016 05:44 PM, Nathaniel McCallum wrote:
>>>> On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote:
>>>>> On 05/12/2016 11:13 PM, Nathaniel McCallum wrote:
>>>>>> On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> the patch adds webui part for authentication indicators.
>>>>>>>
>>>>>>> Ticket: https://fedorahosted.org/freeipa/ticket/5872
>>>>>> The otp option displays as: OTP.
>>>>>> The radius option displays as: Radius.
>>>>>>
>>>>>> However, both are acronyms. The capitalization should be
>>>>>> consistent.
>>>>> I'm sorry for late answer. They are displayed this way: 'OTP' and
>>>>> 'Radius'. So it should not require any change.
>>>> That is incorrect. It should be: OTP and RADIUS.
>>> I'm sorry, I didn't understand correctly. Fixed patch attached.
>>>
>>>
>>>
>> The last patch changes the 'Radius' to 'RADIUS' in whole WebUI.
>>
> After some though, we should really support the arbitrary values also in
> Web UI.
>
> I'd reuse aci.attributes_widget - move the widget elsewhere, make it a
> general widget and a base class for the original aci.attributes_widget.
>
> The only difference should be populate method and some strings.
>
> The base widget can populate from options - same as normal checkboxes
> widget so that service page doesn't need to inherit from the base class.
>
Ok, thank you for advice. The edited patch is attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0034-4-Auth-Indicators-webUI-part.patch
Type: text/x-patch
Size: 23291 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160606/0712e84a/attachment.bin>