[Freeipa-devel] [TESTS][PATCH 0010] WebUI tests - ID views
Pavel Vomacka
pvomacka at redhat.com
Fri Mar 11 09:12:32 UTC 2016
On 03/08/2016 02:34 PM, Lenka Doudova wrote:
>
>
> On 03/08/2016 12:43 PM, Pavel Vomacka wrote:
>>
>>
>> On 02/23/2016 03:20 PM, Lenka Doudova wrote:
>>> Hi,
>>>
>>> attached is patch providing missing test coverage for ID views in
>>> webUI.
>>>
>>> Lenka
>>>
>>>
>> Hi,
>>
>> Thank you for your patch. I have small one comment: The
>> delete_associtaion() function duplicates code, it would be good to
>> create auxiliary function and move that code there. NACK.
>>
>> --
>> Pavel^3 Vomacka
>>
>>
> Hi,
>
> thanks for review, fixed patch attached.
>
> Lenka
>
>
Thank you, ACK.
--
Pavel^3 Vomacka
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160311/850a584f/attachment.htm>
More information about the Freeipa-devel
mailing list