[Freeipa-devel] [PATCH] 0002 New User Role Tests

Martin Basti mbasti at redhat.com
Mon May 9 11:04:15 UTC 2016



On 09.05.2016 12:19, Peter Lacko wrote:
> +# pylint: disable=unicode-builtin
I'm not doing complete review, just the line above hit my eyes.

unicode() is not in Py3 because all strings there are unicode, thus you 
cannot use it directly, you need something like

if six.PY2:
     str = unicode

and use str() everywhere and remove that #pylint line

FYI all enabled pylint checks are there for a good reason, be careful 
with disabling it (mainly disabling it for a whole module) rather ask 
before if you are not sure.

Martin^2




More information about the Freeipa-devel mailing list