[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

[mbasti-rh]

  URL: https://github.com/freeipa/freeipa/pull/145
Title: #145: Refactoring: LDAP Connection Management

mbasti-rh commented:
"""
I don't like `_missing` value in ldap2 class for time and sizelimit

IIUC then `_missing` means that by default the search is unlimited. Why we just dont create constants for unlimited search and use it, it is more clear than combinations of three types `_missing`, Int and None

```
class LDAPClient(object):

SIZE_NOLIMIT = 0
TIME_NOLIMIT = -1.0


class ldap2(CrudBackend, LDAPClient)

   def create_connection(..., time_limit=TIME_NOLIMIT, size_limit=SIZE_NOLIMIT):
   ...
```

"""

See the full comment at https://github.com/freeipa/freeipa/pull/145#issuecomment-258193578