[Freeipa-devel] [PATCH] webui: 0084, 0101: refactoring rpc module

[Petr Vobornik]

On 08/09/2016 01:29 PM, Pavel Vomacka wrote:
> Hello,
> 
> please review attached patches.
> 
> The rpc module is now separated from display layer
> and changing activity text while loading metadata.
> 
> https://fedorahosted.org/freeipa/ticket/6144
> 
> 
> 

patch 84:

Looks good, works fine, it just needed rebase(I could provide that).

Idea, but that doesn't have to be implemented, or sometime in future,
right now it is not useful: What about providing the rpc object in the
event, and having unique id for each rpc call so that we could track all
rpc which are executed.


patch 101:

1. It's event name but the property name looks like that it contains a text:
   that.change_text = 'change-activity-text';

Should it be rather: that.change_text_event.

Or even, why does it compare previous text? Does it matter? Wouldn't be
better to have 'set-activity' event. And then the handler would call
something new set_text method:

set_text(new_activity)
  that.dots = 0
  that.text = new_activity
  that.make_step()


-- 
Petr Vobornik